-
-
Notifications
You must be signed in to change notification settings - Fork 702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed all imports from barrel files for components, actions, helpers, hooks and lodash #6509
Conversation
…s, hooks and lodash
✅ Deploy Preview for plone-components canceled.
|
@stevepiercy I realized the deprecation docs for this already existed, I added a couple extra files I cleaned up. |
FYI: this PR also reduces the main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just add a couple of periods, then I approve docs and news.
Out of curiosity, did you do all this manually or with a tool that finds barrel imports and replaces them? This is a huge amount of changes!
Co-authored-by: Steve Piercy <[email protected]>
@stevepiercy All manually :) I figured that I would have had a lot of 30 to 60 minutes slots during the conf sprint, the following day, the flights and the long layovers, so this task would have been a good fit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs and news approved. Still needs tech review.
Needs an ESLint fix, then should be good to merge. |
This reverts commit c9e3dfd.
@pnicolli now should be green, let's merge it and release it. |
@pnicolli just realised of something: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and ready to merge.
@pnicolli waiting for your last ack.
9c42587
to
a118254
Compare
@sneridagh @pnicolli Are we merging this for Volto 18 or 19? If it's for 18, it's a bit late (we already made non-alpha releases and this is breaking). If it's for 19, fine, but then we need to cut an 18.x branch and start using main for 19. |
@sneridagh @pnicolli Oh sorry, now that I actually read the PLIP, I understand that this is fixing the imports in Volto core but not actually removing the barrels yet. Okay! |
I found another barrel file that I didn't see in the first iteration, I worked on it last night, will finish asap. |
@davisagli yes, we realised that the work of moving all the imports to direct imports is fine and non-breaking. This will also enable right now multi-framework add-ons :) |
Ok added the last small commit, now I think it's good to go @sneridagh |
* main: Commit missing README from release Release 18.2.0 Release @plone/slate 18.0.2 Removed all imports from barrel files for components, actions, helpers, hooks and lodash (#6509)
Closes #6507